Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Changes to Support section 9.1 of ARIA spec #40071

Merged
merged 10 commits into from
May 19, 2023
Merged

Conversation

jnurthen
Copy link
Contributor

@jnurthen jnurthen commented May 17, 2023

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new files look great. Thanks.

Please associate the issues it will close and move the new tests out of basic.html.

wai-aria/role/basic.html Outdated Show resolved Hide resolved
wai-aria/role/abstract-roles.html Show resolved Hide resolved
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a few additions

wai-aria/role/basic.html Outdated Show resolved Hide resolved
wai-aria/role/fallback-roles.html Show resolved Hide resolved
wai-aria/role/form-roles.html Outdated Show resolved Hide resolved
wai-aria/role/invalid-roles.html Show resolved Hide resolved
jnurthen and others added 4 commits May 18, 2023 15:28
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen jnurthen merged commit 5d3676c into master May 19, 2023
@jnurthen jnurthen deleted the jnurthen/tests_for_9_1 branch May 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WPT tests for section 9.1 - handling Author errors Roles abstract role tests
3 participants