selectlist: Implement new keyboard behavior #42068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 19, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4876791
branch
from
ab8d967
to
ca88e63
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4876791
branch
3 times, most recently
from
475f71f
to
a9ec75e
Compare
This patch implements several keyboard behaviors: - Enter while the listbox is closed should not open the listbox and should instead submit the form. - Enter while the listbox is open should select/commit the currently focused option and close the listbox. - Space should open the listbox. - Arrow keys while the listbox is open should not commit the newly focused value. - Arrow keys while the listbox is closed should open the listbox. These were resolved on in OpenUI here: - openui/open-ui#433 (comment) - openui/open-ui#386 (comment) - openui/open-ui#742 This patch also implements the resolution here to stop changing the visible value of the selected option while the user is switching the focused option using the arrow keys: Fixed: 1422275 Change-Id: If5e7328ad739f9c7339dcd17561c57875d4255e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876791 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1207785}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4876791
branch
from
a9ec75e
to
d61c0f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements several keyboard behaviors:
should instead submit the form.
focused option and close the listbox.
focused value.
These were resolved on in OpenUI here:
<selectmenu>eagerly makes selections openui/open-ui#742This patch also implements the resolution here to stop changing the
visible value of the selected option while the user is switching the
focused option using the arrow keys:
Fixed: 1422275
Change-Id: If5e7328ad739f9c7339dcd17561c57875d4255e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876791
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207785}