feat: add npm package provenance #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> a verifiable way to link a package back to its source repository and the specific build instructions used to publish it. - publish to npm with provenance flag - update checkout and setup-node actions to v4 see: https://github.blog/2023-04-19-introducing-npm-package-provenance/ License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
vasco-santos
approved these changes
Nov 22, 2023
we test as part of the releae step License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
pushed a commit
that referenced
this pull request
Nov 22, 2023
🤖 I have created a release *beep* *boop* --- ## [6.1.0](v6.0.0...v6.1.0) (2023-11-22) ### Features * add npm package provenance ([#135](#135)) ([9b1697c](9b1697c)) ### Bug Fixes * update deps. pull in w3up-client fixes ([#133](#133)) ([6aacec8](6aacec8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
achingbrain
reviewed
Nov 22, 2023
Comment on lines
+9
to
+12
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
I found this useful after debugging a couple of failures in the js-libp2p repo - https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28
Basically only id-token and contents need write perms.
There was a problem hiding this comment.
To answer my own question it looks like contents is needed to create releases and pull-requests is to create the release PR.
There was a problem hiding this comment.
That's the one. When I added the id token permission release-please started failing until i added the other perms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://github.blog/2023-04-19-introducing-npm-package-provenance/
License: MIT