Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Rename fromString -> fromText #5

Closed
olizilla opened this issue Jul 1, 2021 · 2 comments · Fixed by #4
Closed

Rename fromString -> fromText #5

olizilla opened this issue Jul 1, 2021 · 2 comments · Fixed by #4

Comments

@olizilla
Copy link

olizilla commented Jul 1, 2021

Should fromString be fromText to hint at the fact that it's just going to call TextEncoder.encode() on it, and it's other side of Blob.text https://developer.mozilla.org/en-US/docs/Web/API/Blob/text
@vasco-santos
Copy link
Contributor

#4 😛

@vasco-santos vasco-santos mentioned this issue Jul 1, 2021
Merged
@olizilla olizilla mentioned this issue Jul 1, 2021
Merged
3 tasks
@olizilla
Copy link
Author

olizilla commented Jul 1, 2021

awww man. You are way ahead of me @vasco-santos

@dchoi27 dchoi27 reopened this Aug 1, 2021
@dchoi27 dchoi27 closed this as completed Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add text support web3-storage/web3-file
3 participants
@olizilla @vasco-santos @dchoi27