Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styling to the homepage #137

Merged
merged 1 commit into from
Jul 23, 2021
Merged

feat: add styling to the homepage #137

merged 1 commit into from
Jul 23, 2021

Conversation

jdiogopeixoto
Copy link
Contributor

  • Adds styles to the homepage with a lot of absolute positioning

⚠️ What's missing

  • Add tabs and copy to clipboard button for the code section
  • Improve mobile for the code section

📷 Screenshots

image
image

@jdiogopeixoto jdiogopeixoto self-assigned this Jul 23, 2021
@jdiogopeixoto jdiogopeixoto requested review from alanshaw and rafaelramalho19 and removed request for alanshaw July 23, 2021 11:33
* @param {any} props
*/
const HeroBackgroundLeft = (props) => (
<svg {...props} version="1.2" baseProfile="tiny-ps" xmlns="http://www.w3.org/2000/svg" width="140" height="752"><style></style><path id="Layer" d="M1440 692s0 60-86 60H130L0 613V-50h1440v742z" fill="#fc6553"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This svg is not optimized, has a lot of non-important metadata

* @param {any} props
*/
const HeroBackgroundRight = (props) => (
<svg {...props} version="1.2" baseProfile="tiny-ps" xmlns="http://www.w3.org/2000/svg" width="140" height="752"><style></style><path id="Layer" d="M140 692s0 60-86 60h-1224l-130-139V-50H140v742z" fill="#fc6553"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this one

@alanshaw
Copy link
Member

@jdiogopeixoto would you mind resolving conflicts so we can merge?

@alanshaw alanshaw merged commit 673a32c into main Jul 23, 2021
@alanshaw alanshaw deleted the feat/homepage-style branch July 23, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants