feat: add w3up-launch announcement banner (when env.NEXT_PUBLIC_W3UP_LAUNCH_SUNSET_ANNOUNCEMENT_START is set) #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
gobengo
changed the title
… named either staging or preview-{github.ref_name}
gobengo
commented
Nov 8, 2023
packages/website/pages/index.js
Outdated
| <main className="page page-index"> | ||
| {sections.map((section, index) => ( | ||
| <BlockBuilder id={`section_${index + 1}`} key={`section_${index + 1}`} subsections={section} /> | ||
| ))} | ||
| </main> | ||
|
|
||
| <Scroll2Top /> |
There was a problem hiding this comment.
When this was present, it was weirdly somehow resulting in an element from inside the scroll2top component getting mixed up with the PageBanner children. It happened in firefox and chrome, and I have no idea how.... The scroll2top component code seems relatively innocuous so I don't know why it would affect dom manip. The only way to fix was to not use the component here. I know its dumb, but without this, the bug in the dom that react rendered made the home page banner not render at all.
workaround: remove this Scroll2Top for now. We can add it back in later if we really need it, but we probably don't, and this whole website is being sunset anyway!
travis
approved these changes
Nov 8, 2023
gobengo
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [2.37.0](website-v2.36.3...website-v2.37.0) (2023-11-09) ### Features * add w3up-launch announcement banner (when env.NEXT_PUBLIC_W3UP_LAUNCH_SUNSET_ANNOUNCEMENT_START is set) ([#2319](#2319)) ([f3d5b97](f3d5b97)) * remove 'whats the data layer?' cta2 from website homepage ([#2322](#2322)) ([7975fdf](7975fdf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Tactics:
NEXT_PUBLIC_W3UP_LAUNCH_SUNSET_ANNOUNCEMENT_STARTthat is an ISO8601 datetime of when the announcement should appear. If unset, the announcement will never appear. My intention is to set it only on the staging environment for acceptance testing. Once we're happy on staging, we can enable it on production by setting this var to whatever datetime we want it to appear.Scope:
websiteworkflow now uses github environments. This is because I want to use them to configure the staging environment to have a particular value forNEXT_PUBLIC_W3UP_LAUNCH_SUNSET_ANNOUNCEMENT_START