Skip to content

Commit

Permalink
types(web3-core-helpers): fix disconnect args
Browse files Browse the repository at this point in the history
This commit makes WebsocketProviderBase.disconnect arguments optional in the type declaration file, since they have a default value in the JavaScript implementation for the 2.x branch and the arguments aren't even present in the 1.x branch.
  • Loading branch information
lautarodragan committed Nov 19, 2019
1 parent 5c78c2b commit 27a5e7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/web3-core-helpers/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class WebsocketProviderBase {

reset(): void;

disconnect(code: number, reason: string): void;
disconnect(code?: number, reason?: string): void;
}

export class IpcProviderBase {
Expand Down

0 comments on commit 27a5e7f

Please sign in to comment.