Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLEASE PROVIDE SENSIBLE ERRORS #1543

Closed
beether opened this issue Apr 12, 2018 · 7 comments
Closed

PLEASE PROVIDE SENSIBLE ERRORS #1543

beether opened this issue Apr 12, 2018 · 7 comments
Assignees
Labels
2.x 2.0 related issues Enhancement Includes improvements or optimizations Stale Has not received enough activity

Comments

@beether
Copy link

beether commented Apr 12, 2018

"Invalid number of solidity arguments" is AIDS.

You have the freaking ABI that defines which inputs are expected, their order, and their type. Why such a miserable error message? FFS... it's so unnecessarily difficult to debug this error, especially since you (rather idiotically) try to infer the different inputs (which CAN be objects) from the transaction options (which IS an object).

It infuriates me, and countless others.

JUST FREAKING FIX THIS. LET ME PASS AN ARRAY OF INPUTS.

@Andromelus
Copy link

Your demand might be legit, but the way you demand it is not. They work for you, at least respect it.

@frozeman
Copy link
Contributor

frozeman commented Apr 12, 2018

:)
In 1.0 there is no transaction object anymore.
And yes the error could be more concise, and as this is an open source projects youre welcome to make the change, PR and we discuss ;)

@beether
Copy link
Author

beether commented Apr 12, 2018

So, in other words, it's not a priority to fix this, even though pretty much all dApp developers need to target MetaMask, which uses v0.2.x. v1 is great and I love the design and can't wait to use it... but It's really annoying that you don't seem to care about making actual development easier, and quite telling that your response is "it's open source, take it or leave it"

On an unrelated note, v1 could have been made to wrap 0.2.x, allowing it to be backward compatible, and allowing everyone in the world to immediately use it with MetaMask. Not a priority, I suppose.

@beether
Copy link
Author

beether commented Apr 12, 2018

@Andromelus what do you mean "they work for you"?

@nick
Copy link

nick commented Apr 17, 2018

@nivida nivida self-assigned this Aug 9, 2018
@nivida nivida added the Enhancement Includes improvements or optimizations label Aug 9, 2018
@nivida
Copy link
Contributor

nivida commented Nov 29, 2018

@beether I will implement the Winston logger for a better and consistent error handling.

@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x 2.0 related issues Enhancement Includes improvements or optimizations Stale Has not received enough activity
Projects
None yet
Development

No branches or pull requests

5 participants