Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't auto transform bytes(X) to string and introduce string as a new type for solidity contracts #216

Closed
frozeman opened this issue May 23, 2015 · 1 comment
Closed

Don't auto transform bytes(X) to string and introduce string as a new type for solidity contracts #216

frozeman opened this issue May 23, 2015 · 1 comment
Labels
Bug Addressing a bug

Comments

@frozeman
Copy link
Contributor

Currently bytes sometimes get decoded wrong, which make it impossible to use bytes as non-strings, because you can't reliable encode them back to bytes.

web3.toAscii('731a3afc00d1b1e3461b955e53fc866dcf303b3eb9f4c16f89e388930f48134b')
"s:ü"

web3.toAscii('731a3afc')
"s:ü"

Instead we need to re-introduce the string type in solidity and only decode this one to strings and keep bytes as is: https://www.pivotaltracker.com/n/projects/1189488/stories/95173586
@frozeman frozeman added the Bug Addressing a bug label May 23, 2015
@ethers
Copy link
Contributor

ethers commented May 29, 2015

related to #218

debris added a commit that referenced this issue Jun 1, 2015
@debris
abi string type, fixes #216, #218, #219
fa3239f
frozeman added a commit that referenced this issue Jun 25, 2015
@frozeman
Merge pull request #228 from ethereum/strings
4a46c73 
abi string type, fixes #216, #218, #219
@snyk-bot snyk-bot mentioned this issue Jan 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frozeman @ethers