Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexToNumberString sometimes interprets string as decimal #2184

Closed
wjmelements opened this issue Jan 12, 2019 · 4 comments · Fixed by #2884
Closed

hexToNumberString sometimes interprets string as decimal #2184

wjmelements opened this issue Jan 12, 2019 · 4 comments · Fixed by #2884
Labels
Bug Addressing a bug

Comments

@wjmelements
Copy link 

> web3.utils.hexToNumberString('13')
'13'
@nivida nivida added the Bug Addressing a bug label Jan 18, 2019
princesinha19 added a commit to princesinha19/web3.js that referenced this issue Mar 26, 2019
@princesinha19
Solved bug listed in web3#2184. Now, it properly converts the hex val…
b5536bd 
…ue to number string. Also, solved a similar bug on line 271.
@princesinha19 princesinha19 mentioned this issue Mar 27, 2019
Closed
12 tasks
@levino
Copy link
Contributor

levino commented Apr 15, 2019

Thank you for this issue. Please link to the subpage in the docs where the expected behaviour is documented.

@levino
Copy link
Contributor

levino commented Apr 15, 2019

https://web3js.readthedocs.io/en/1.0/web3-utils.html?highlight=hexToNumberString#hextonumberstring

@levino
Copy link
Contributor

levino commented Apr 15, 2019 •
edited
Loading

When I read the docs it looks to me as if a hex-string must be prefixed with 0x, right? What is the expected behaviour from the documentation? So the issue should rephrased to:

Throw error when argument of hexToNumberString is not prefixed with 0x.

@levino
Copy link
Contributor

levino commented Apr 15, 2019

This should be made ready for dev and then go directly to "To Do" as a bug.

@yzevm yzevm mentioned this issue Jun 10, 2019
Merged
5 tasks
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
@cgewecke cgewecke mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(utils): hexToNumberString prefix validation
3 participants
@wjmelements @levino @nivida