-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track transaction hash changed [Feature request] #2525
Comments
Could you update your issue to be aligned with the issue template we provide? |
@nivida updated 👌 |
Also observing this behavior. web3 is not catching the completion of a transaction. promise never resolves when you |
simple to reproduce:
promise never resolves. tested in chrome with metamask. using vue/webpack and latest web3 still stuck on web3 beta 0.37 which works |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions |
Any updates? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Oh no 😔 |
@k06a check out #3585 (comment) |
Description
I think web3 should handle if wallet resends tx with a different
gasPrice
. Transactions could be tracked byfrom
(recovered from signature) andnonce
instead oftransactionHash
, and in case of onlygasPrice
andtransactionHash
andsignature
changed it should succeed.Also, it may be reasonable to add callbacks for
hashChanged
event.Steps to reproduce the behavior
And resend Tx with same
nonce
bug differentgasPrice
using a wallet (MetaMask)Expected behavior
Web3 to indicate when transaction succeed or reverted
Actual behavior
Web3 does not indicate when transaction succeed or reverted
Versions
The text was updated successfully, but these errors were encountered: