Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track transaction hash changed [Feature request] #2525

Closed
k06a opened this issue Mar 18, 2019 · 9 comments
Closed

Track transaction hash changed [Feature request] #2525

k06a opened this issue Mar 18, 2019 · 9 comments
Labels
2.x 2.0 related issues Feature Request Stale Has not received enough activity

Comments

@k06a
Copy link

k06a commented Mar 18, 2019

Description

I think web3 should handle if wallet resends tx with a different gasPrice. Transactions could be tracked by from (recovered from signature) and nonce instead of transactionHash, and in case of only gasPrice and transactionHash and signature changed it should succeed.

Also, it may be reasonable to add callbacks for hashChanged event.

Steps to reproduce the behavior

const tx = await web3.eth.sendTransaction(...);

And resend Tx with same nonce bug different gasPrice using a wallet (MetaMask)

Expected behavior

Web3 to indicate when transaction succeed or reverted

Actual behavior

Web3 does not indicate when transaction succeed or reverted

Versions

  • web3.js: 1.0.0-beta.48
@nivida
Copy link
Contributor

nivida commented Mar 18, 2019

Could you update your issue to be aligned with the issue template we provide?
I like this idea. It would be possible with extending of the TransactionObserver and AbstractObservedTransactionMethod class.

@k06a
Copy link
Author

k06a commented Mar 19, 2019

@nivida updated 👌

@mjdietzx
Copy link

mjdietzx commented Apr 3, 2019

Also observing this behavior. web3 is not catching the completion of a transaction. promise never resolves when you send a transaction

@mjdietzx
Copy link

mjdietzx commented Apr 3, 2019

simple to reproduce:

const promise = contract.methods[method](...args).send();

promise never resolves. tested in chrome with metamask. using vue/webpack and latest web3

still stuck on web3 beta 0.37 which works

@nivida nivida added the 2.x 2.0 related issues label Jun 20, 2019
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions

@github-actions github-actions bot added the Stale Has not received enough activity label Jul 4, 2020
@k06a
Copy link
Author

k06a commented Jul 4, 2020

Any updates?

@github-actions github-actions bot removed the Stale Has not received enough activity label Jul 5, 2020
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Aug 4, 2020
@k06a
Copy link
Author

k06a commented Aug 11, 2020

Oh no 😔

@ryanio
Copy link
Collaborator

ryanio commented Aug 11, 2020

@k06a check out #3585 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x 2.0 related issues Feature Request Stale Has not received enough activity
Projects
None yet
Development

No branches or pull requests

4 participants