Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter should be optional in EventOptions #2554

Closed
dileepfrog opened this issue Mar 21, 2019 · 0 comments
Closed

filter should be optional in EventOptions #2554

dileepfrog opened this issue Mar 21, 2019 · 0 comments
Labels
Types Incorrect or missing types

Comments

@dileepfrog
Copy link

Description

The filter parameter is not required for getPastEvents and so should be marked optional in the
EventOptions interface.

https://github.com/ethereum/web3.js/blob/0473405b906500bb534aa29b577be567348ff4fd/packages/web3-eth-contract/types/index.d.ts#L106
@nivida nivida added the Types Incorrect or missing types label Mar 22, 2019
@nivida nivida mentioned this issue Mar 22, 2019
Merged
12 tasks
@nivida nivida mentioned this issue Mar 28, 2019
Merged
12 tasks
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dileepfrog @nivida