Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-core > @types/bignumber.js@5.0.0 — dependency is apparently not needed #3209

Closed
michaelsbradleyjr opened this issue Nov 14, 2019 · 1 comment · Fixed by #3213
Closed
Labels
1.x 1.0 related issues

Comments

@michaelsbradleyjr
Copy link
Contributor

michaelsbradleyjr commented Nov 14, 2019

When running yarn install in a project that has the latest version web3@1.2.3 as a dependency, I'm getting this in the install output:

warning workspace-aggregator-076b0d0e-a31b-4d15-a5bf-261416e7d734 > embark > web3-core > @types/bignumber.js@5.0.0:
This is a stub types definition for bignumber.js (https://github.com/MikeMcl/bignumber.js/).
bignumber.js provides its own type definitions, so you don't need @types/bignumber.js installed!

[line breaks added by me]

Also, could @types/... dependencies generally be made devDependencies?

NOTE: Did a little reading re @types/... packages and it seems that when authoring a library, it is better to have them in "dependencies" and not "devDependencies" since that will benefit downstream devs authoring in TypeScript.

@wbt
Copy link
Contributor

wbt commented Nov 14, 2019

Just got a similar report when using "npm install web3" on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants