Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reason missing when using geth 1.9.14 #3520

Closed
cgewecke opened this issue May 14, 2020 · 2 comments · Fixed by #3571
Closed

Revert reason missing when using geth 1.9.14 #3520

cgewecke opened this issue May 14, 2020 · 2 comments · Fixed by #3571
Assignees
Labels
1.x 1.0 related issues

Comments

@cgewecke
Copy link
Collaborator

cf: geth 21082

In geth 1.9.14 no data is returned when replaying failing transactions with eth_call which means Web3 cannot extract the reason.

There's a reproduction case at: https://github.com/cgewecke/geth-revert-reason-repro

@cgewecke
Copy link
Collaborator Author

Related: geth PR 21083, which would format reverting eth_call responses as below:

{
  "jsonrpc": "2.0",
  "id": 1,
  "error": {
    "code": -32000,
    "message": "some error"
  }
}

@cgewecke
Copy link
Collaborator Author

cgewecke commented Jun 2, 2020

Note: when this is fixed and geth in CI is restored to stable (instead of 1.9.13), make sure to update the TESTING.md docs to reflect this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant