Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to support eth_maxPriorityFeePerGas method? #4195

Closed
brg8 opened this issue Jul 26, 2021 · 5 comments · Fixed by #6748
Closed

Plans to support eth_maxPriorityFeePerGas method? #4195

brg8 opened this issue Jul 26, 2021 · 5 comments · Fixed by #6748
Assignees
Labels

Comments

@brg8
Copy link

brg8 commented Jul 26, 2021

I've gone through the EIP 1559 PR and could not find support for this new method. There is a separate PR for eth_feeHistory, which is fantastic. What is the reasoning behind ignoring eth_maxPriorityFeePerGas? Your hard work is appreciated!

@GregTheGreek
Copy link
Contributor

Hey! I don't think that's apart of the official spec. If that's changed do you mind pointing me to that documentation we can quickly add it :)

@brg8
Copy link
Author

brg8 commented Jul 26, 2021

You're right! It's not part of the official spec, it's geth specific.

I've done some snooping, but I guess I'll ask here -- do you expose a function to send an arbitrary method call to the provider? So that I can call node-client-specific methods when needed.

Thanks!

@GregTheGreek
Copy link
Contributor

No, but that could be a nice feature.

@spacesailor24 thoughts?

@luu-alex
Copy link
Contributor

Hey, we don't plan on supporting this feature for 1.x, but possibly add this to the roadmap for 4.x. Although if you wanted to add a customRPC call like eth_maxPriorityFeePerGas you can do something like this:

const Web3 = require('web3')
const Method = require('web3-core-method');

const web3 = new Web3("")
web3.eth.customRPC = function (opts) {
    const _this = this;
    const newMethod = new Method({
        name: opts.name,
        call: opts.call,
        params: opts.params || 0,
        inputFormatter: opts.inputFormatter || null,
        outputFormatter: opts.outputFormatter || null,
    })
    newMethod.attachToObject(_this);
    newMethod.setRequestManager(_this._requestManager, _this.accounts)

}
console.log(web3.eth.customRPC)
web3.eth.customRPC({name: "testMethod", call: "eth_testMethod"});

@Muhammad-Altabba
Copy link
Contributor

Reopening this issue as eth_maxPriorityFeePerGas become part of the official specs (https://ethereum.github.io/execution-apis/api-documentation/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants