Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate iban formatter with the inputAddressFormatter in web3-common #4448

Closed
nazarhussain opened this issue Oct 11, 2021 · 1 comment
Closed
Assignees
Labels
4.x 4.0 related In Progress Currently being worked on

Comments

@nazarhussain
Copy link
Contributor

Description

While migrating formatters with #4360, there is one todo left. That can only be done while working on web3-eth-iban package.

https://github.com/ChainSafe/web3.js/blob/b52347012ebc0473280f478487f2aabc1df74ff2/packages/web3-common/src/formatters.ts#L95-L102

Acceptance Criteria

  • The inputAddressFormatter works well with iban address format.
  • The tests are added to check iban formatter

Additional Information

  • Use BigInt where appropriate.
@nazarhussain nazarhussain added the 4.x 4.0 related label Oct 11, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Dec 11, 2021
@mconnelly8 mconnelly8 removed the Stale Has not received enough activity label Jan 10, 2022
@mconnelly8 mconnelly8 reopened this Jan 10, 2022
@mconnelly8 mconnelly8 added the In Progress Currently being worked on label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related In Progress Currently being worked on
Projects
None yet
Development

No branches or pull requests

4 participants