Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement provider.getFeeData() #6599

Closed
Muhammad-Altabba opened this issue Nov 16, 2023 · 1 comment · Fixed by #6795
Closed

Implement provider.getFeeData() #6599

Muhammad-Altabba opened this issue Nov 16, 2023 · 1 comment · Fixed by #6795
Assignees

Comments

@Muhammad-Altabba
Copy link
Contributor

Muhammad-Altabba commented Nov 16, 2023

I suggest to implement provider.getFeeData() similar to https://docs.alchemy.com/reference/sdk-getfeedata and https://docs.ethers.org/v6/single-page/#Provider-getFeeData.

From Alchemy API Reference:

Returns the recommended fee data to use in a transaction. For an EIP-1559 transaction, the maxFeePerGas and maxPriorityFeePerGas should be used.

For legacy transactions and networks which do not support EIP-1559, the gasPrice should be used.

And deprecate getGasPrice (check ethers-io/ethers.js#2439 (reply in thread))

Helpful references:

@Muhammad-Altabba Muhammad-Altabba changed the title [Feature Request] Implement provider.getFeeData() Implement provider.getFeeData() Nov 16, 2023
@Muhammad-Altabba
Copy link
Contributor Author

Muhammad-Altabba commented Nov 28, 2023

And update the documentation according to this. Like in this place and all similar places: https://docs.web3js.org/guides/basics/eth/#eip-1559-transaction

Also look at getFeeHistory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants