From 7e32260fbfa1542ff381e94b8ca1e17f9514fc45 Mon Sep 17 00:00:00 2001 From: Samuel Furter Date: Fri, 29 Mar 2019 12:51:06 +0100 Subject: [PATCH 1/2] Invalid bytes tring error fixed with returning 'null' if the response is '0x' --- packages/web3-eth-contract/src/methods/CallContractMethod.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web3-eth-contract/src/methods/CallContractMethod.js b/packages/web3-eth-contract/src/methods/CallContractMethod.js index 29c62d04972..4126ce9b068 100644 --- a/packages/web3-eth-contract/src/methods/CallContractMethod.js +++ b/packages/web3-eth-contract/src/methods/CallContractMethod.js @@ -49,7 +49,7 @@ export default class CallContractMethod extends CallMethod { * @returns {Array|String} */ afterExecution(response) { - if (!response) { + if (!response || response === '0x') { return null; } From 99d754474c0b3847b007664dd790617bf7dc8e69 Mon Sep 17 00:00:00 2001 From: Samuel Furter Date: Fri, 29 Mar 2019 12:59:55 +0100 Subject: [PATCH 2/2] CallContractMethodTest extended --- .../tests/src/methods/CallContractMethodTest.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/web3-eth-contract/tests/src/methods/CallContractMethodTest.js b/packages/web3-eth-contract/tests/src/methods/CallContractMethodTest.js index e7b6bb75f71..a3b2231b630 100644 --- a/packages/web3-eth-contract/tests/src/methods/CallContractMethodTest.js +++ b/packages/web3-eth-contract/tests/src/methods/CallContractMethodTest.js @@ -61,4 +61,12 @@ describe('CallContractMethodTest', () => { expect(abiCoderMock.decodeParameter).toHaveBeenCalledWith('bytes', '0x0'); }); + + it('calls afterExecution and response is empty', () => { + expect(callContractMethod.afterExecution()).toEqual(null); + }); + + it('calls afterExecution and response has value "0x" is empty', () => { + expect(callContractMethod.afterExecution('0x')).toEqual(null); + }); });