Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes transaction confirmations with the HttpProvider #3140

Merged
merged 9 commits into from
Oct 17, 2019
Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 17, 2019

Back-ports #1239 which is listed in issue #3070.

@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on 1.x 1.0 related issues labels Oct 17, 2019
@nivida nivida requested a review from cgewecke October 17, 2019 09:02
@nivida nivida removed the In Progress Currently being worked on label Oct 17, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 84.465% when pulling d0776ee on back-port/1239 into 400d24b on 1.x.

nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
* confirmations are now only emitted if a new block is actually existing

* CHANGELOG.md updated

* CHANGELOG.md 'Added' section updated with the added types

* build packages updated

* istanbul updated because of the usage of 'async', contract.js test codestyle improved, and transaction confirmation handling in the Method class of the web3-core-method module

* coveralls CI script updated

* coverage paths updated in e2e.ganache.sh, e2e.geth.automine.sh, e2e.geth.instamine.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants