Revert 3123

[cgewecke]

Description

Reverts #3123 - just queuing this up so that it's possible to publish quickly if necessary.

#3123 fixed a bug in the expression which evaluates tx success/error conditions for pre-byzantium chains. However it broke expected behavior for post-byzantium chains such that calls which supply the perfect amount of gas now error even though the transaction succeeded.

Ex:

web3.eth.sendTransaction({
  from: accounts[0],
  to: accounts[1],
  value: web3.utils.toWei('1', 'ether'),
  gas: 21000
})

There's ongoing work to resolve this to everyone's satisfaction in #3189 (but no agreement yet).

Fixes #3175

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run test with success and extended the tests if necessary.
• I ran npm run build and tested the resulting file from dist folder in a browser.
• I have tested my code on the live network.

[coveralls]

Coverage remained the same at 84.347% when pulling c3bfcac on issue/3175-hotfix into 22df832 on 1.x.

[nivida]

@cgewecke Thanks for providing this hotfix! 💪