Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines corejs v2 in the gulpfile #3205

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 14, 2019

Description

The corejs options property was missing in the babel config and brought up a warning during bundling of web3.js. Instead of letting babel choose automatically version 2 of it do we now defined it explicit.

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

…plicit defined in babel config of the gulpfile
@nivida nivida added Enhancement Includes improvements or optimizations 1.x 1.0 related issues labels Nov 14, 2019
@nivida
Copy link
Contributor Author

nivida commented Nov 14, 2019

@cgewecke Merged without review because it doesn't change any logic and just defines the anyways chosen setting explicit.

@nivida nivida merged commit df9c21d into 1.x Nov 14, 2019
@nivida nivida deleted the enhancement/explicit-defining-of-corejs branch November 14, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant