Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security patch changes applied on 1.x #3355

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Security patch changes applied on 1.x #3355

merged 2 commits into from
Feb 2, 2020

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 2, 2020 •
edited
Loading

Description

This PR updates the registry address on 1.x, the CHANGELOG.md file, and the package.json / package-lock.json files of all packages. Those changes do come from the release PR we sadly can't merge back into 1.x.

Type of change

  • Release changes

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added the 1.x 1.0 related issues label Feb 2, 2020
@nivida nivida mentioned this pull request Feb 2, 2020
Closed
10 tasks
alcuadrado
alcuadrado approved these changes Feb 2, 2020
View reviewed changes
Copy link

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivida nivida merged commit 04c8d65 into 1.x Feb 2, 2020
@nivida nivida removed the request for review from cgewecke February 2, 2020 13:14
@nivida nivida mentioned this pull request Feb 2, 2020
Merged
12 tasks
@nivida nivida deleted the security-patch/ens branch February 2, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nivida @alcuadrado