Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-scripts to lerna publish command for E2E publishing tests #3472

Closed
wants to merge 7 commits into from

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Apr 15, 2020

Description

PR targets #3470

In #3470, the publishing steps are managed with npm lifecycle scripts. However the E2E npm installation tests don't install the dev dependencies required for the build (in order to preserve as much dep. isolation as possible) so that step fails.

We don't use the minified bundle in these tests so we can safely skip here...

The target branch for this is an open question...it might be nice to see those tests pass for the release and they're intended as pre-publication sanity checks. On the other hand maybe this fix belongs outside the release process.

(The tests pass here ... it could be floated in next week after the release is complete)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@cgewecke cgewecke added the 1.x 1.0 related issues label Apr 15, 2020
@ryanio ryanio changed the base branch from release/1.2.7 to 1.x April 24, 2020 19:23
@cgewecke
Copy link
Collaborator Author

Closing in favor of #3487 because merge conflicts ooc.

@cgewecke cgewecke closed this Apr 27, 2020
@cgewecke cgewecke deleted the fix/allowed-failures branch April 27, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants