Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark html file with commit & branch in surge e2e test #3476

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Apr 15, 2020

Description

Adds info to test html which lets us verify that we're looking at the latest state

For the merge commit fff3245, http://sudden-playground.surge.sh/ looked like:

Screen Shot 2020-04-17 at 3 10 30 PM

Fixes #3471

Type of change

  • Test improvement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@cgewecke cgewecke added the 1.x 1.0 related issues label Apr 17, 2020
scripts/e2e.cdn.sh Outdated Show resolved Hide resolved
scripts/e2e.cdn.sh Outdated Show resolved Hide resolved
@cgewecke cgewecke requested a review from ryanio April 17, 2020 22:21
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ryanio ryanio merged commit 0aef44e into 1.x Apr 17, 2020
@GregTheGreek GregTheGreek deleted the issue/3471 branch July 26, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject commit hash into scripts/html/index.html for Surge E2E test
2 participants