Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build error from dtslint #3479

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Fix CI build error from dtslint #3479

merged 2 commits into from
Apr 17, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Apr 17, 2020

Description

This PR fixes intermittent CI build failures due to dtslint erroring out on installing TypeScript 3.9.

As a workaround we install the latest typescript into each package and use the --localTs option. It's not ideal since we only test the types against one version, but it was the existing behavior prior to #3464 where I attempted to expand it. This PR also removes the now unnecessary // Minimum TypeScript Version comments I put in to satisfy testing against prior versions in that PR.

This PR also removes the devDep definitelytyped-header-parser sincedtslint automatically includes it as a child dep and outdated pinned versions may cause future dtslint issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added 1.x 1.0 related issues CI labels Apr 17, 2020
@ryanio ryanio mentioned this pull request Apr 17, 2020
13 tasks
@cgewecke cgewecke self-requested a review April 17, 2020 21:15
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. LGTM.

@ryanio ryanio merged commit a0400fb into 1.x Apr 17, 2020
@holgerd77 holgerd77 deleted the fix-CI-build branch April 17, 2020 22:00
@ryanio ryanio mentioned this pull request May 8, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants