Add function compareBlockNumbers(a, b) #3540
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes it is useful to be able to compare block numbers, which is slightly more complicated than usual because of the option for predefined string block numbers.
This PR offers a starting point for a new function which can help with that.
I located it near other functions that seem logically related.
Collaborative development is invited to address any edge case/logical errors missed in the first draft, the following shortcomings, and unchecked boxes below:
Until such time as this is merged in with web3, the code may be used in a repository that uses web3 under the same license.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build-all
and tested the resulting files fromdist
folder in a browser.CHANGELOG.md
file in the root folder.