Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include prs with stalebnot #3658

Merged
merged 2 commits into from
Jul 26, 2020
Merged

include prs with stalebnot #3658

merged 2 commits into from
Jul 26, 2020

Conversation

GregTheGreek
Copy link
Contributor

@GregTheGreek GregTheGreek commented Jul 26, 2020

Description

Stalebot was previously only configured for issues, figured its worth adding to PR's so we can keep track of contributions that might have gotten stale/out-dated

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@GregTheGreek GregTheGreek added Enhancement Includes improvements or optimizations CI labels Jul 26, 2020
@coveralls
Copy link

coveralls commented Jul 26, 2020

Coverage Status

Coverage remained the same at 84.321% when pulling a92441f on greg/ci/stale-bot-pr into 1fc6217 on 1.x.

Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@GregTheGreek GregTheGreek merged commit bf06daa into 1.x Jul 26, 2020
@GregTheGreek GregTheGreek deleted the greg/ci/stale-bot-pr branch July 26, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants