Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3.shh.post example update #3668

Merged
merged 5 commits into from
Aug 8, 2020
Merged

web3.shh.post example update #3668

merged 5 commits into from
Aug 8, 2020

Conversation

daoauth
Copy link
Contributor

@daoauth daoauth commented Aug 3, 2020

Description

example has a bug

var identities = [] -> var identities = {}
shh.subscribe -> web3.shh.subscribe

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

var identities = []; -> var identities = {};
@coveralls
Copy link

coveralls commented Aug 3, 2020

Coverage Status

Coverage remained the same at 84.342% when pulling d6f8134 on daoauth:patch-2 into 80c2834 on ethereum:1.x.

Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like line 772 is missing web3 from web3.shh.subscribe...

Other changes make the example for legible

@daoauth daoauth closed this Aug 7, 2020
@daoauth daoauth reopened this Aug 7, 2020
@GregTheGreek
Copy link
Contributor

This is ready, just updating the branch

@GregTheGreek GregTheGreek merged commit e31a9db into web3:1.x Aug 8, 2020
@GregTheGreek
Copy link
Contributor

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants