Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function compare blocks #3682

Merged
merged 13 commits into from
Sep 1, 2020
Merged

Add function compare blocks #3682

merged 13 commits into from
Sep 1, 2020

Conversation

GregTheGreek
Copy link
Contributor

@GregTheGreek GregTheGreek commented Aug 11, 2020

Description

I'm still adding more tests, but its looking fine as is.

From original PR:

Sometimes it is useful to be able to compare block numbers, which is slightly more complicated than usual because of the option for predefined string block numbers.

Supersedes #3540

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@GregTheGreek GregTheGreek added Enhancement Includes improvements or optimizations 1.x 1.0 related issues labels Aug 11, 2020
@GregTheGreek GregTheGreek changed the title New function compare blocks Add function compare blocks Aug 11, 2020
@coveralls
Copy link

coveralls commented Aug 11, 2020

Coverage Status

Coverage decreased (-6.3%) to 78.056% when pulling 488135d on greg/compareblocks into 9edd908 on 1.x.

@GregTheGreek GregTheGreek marked this pull request as ready for review August 18, 2020 10:03
@GregTheGreek GregTheGreek merged commit f33e5d5 into 1.x Sep 1, 2020
@GregTheGreek GregTheGreek deleted the greg/compareblocks branch September 1, 2020 11:19
@GregTheGreek GregTheGreek mentioned this pull request Sep 2, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants