Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.x with 1.x #4197

Merged
merged 13 commits into from
Jul 28, 2021
Merged

Update 3.x with 1.x #4197

merged 13 commits into from
Jul 28, 2021

Conversation

spacesailor24
Copy link
Contributor

No description provided.

spacesailor24 and others added 13 commits July 26, 2021 14:07
* Update changelog

* Built dist

* Update version numbers

* v1.3.5

Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal>
* adding function unsubscribe by id

* adding an unsubscribe testcase

* adding testcase

* seperated unsubscribebyid to its own method

* adding testcases

* adding await

* fixing testcases

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>
Test don't run when only changes to `CHANGELOG.md` have been made
@spacesailor24 spacesailor24 added the 3.x 3.0 related issues label Jul 27, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1069829840

  • 17 of 78 (21.79%) changed or added relevant lines in 5 files are covered.
  • 334 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.9%) to 75.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-core-helpers/src/formatters.js 7 8 87.5%
packages/web3-utils/src/soliditySha3.js 0 3 0.0%
packages/web3-utils/src/utils.js 0 3 0.0%
packages/web3-utils/src/index.js 1 7 14.29%
packages/web3-eth-accounts/src/index.js 9 57 15.79%
Files with Coverage Reduction New Missed Lines %
packages/web3-eth/lib/getNetworkType.js 3 86.79%
packages/web3-core-helpers/src/formatters.js 4 79.6%
packages/web3-eth-ens/lib/lib/ResolverMethodHandler.js 5 87.88%
packages/web3-utils/src/utils.js 5 8.46%
packages/web3-core-method/lib/index.js 6 94.95%
packages/web3-eth-ens/lib/ENS.js 6 93.39%
packages/web3-core-subscriptions/lib/subscription.js 7 91.98%
packages/web3-eth-abi/lib/index.js 8 90.24%
packages/web3-eth-ens/lib/contracts/Registry.js 9 89.27%
packages/web3-core-requestmanager/lib/index.js 10 83.63%
Totals Coverage Status
Change from base Build 731829524: -0.9%
Covered Lines: 3133
Relevant Lines: 3945

💛 - Coveralls

@spacesailor24 spacesailor24 merged commit e099b9d into 3.x Jul 28, 2021
@spacesailor24 spacesailor24 deleted the wyatt/update-3.x-2 branch July 28, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x 3.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants