Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in ENSTests #716

Closed
janndriessen opened this issue Dec 22, 2022 · 5 comments
Closed

Fix warnings in ENSTests #716

janndriessen opened this issue Dec 22, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@janndriessen
Copy link
Collaborator

What happened?

There is some warnings in the ENSTests.

Make sure to check if the tests work correctly and if the constant names could just be replaced with _ - as suggested by the compiler.

What are the steps to reproduce?

Check build warnings in Xcode.

What is the expected behavior?

No warnings.

What is the error thrown?

Build warnings in Xcode.

What's the stack trace said?

...

OS version

macOS 13.0.1

Library version

3.0.6

@janndriessen janndriessen added bug Something isn't working good first issue Good for newcomers labels Dec 22, 2022
@albertopeam
Copy link
Contributor

it seems easy, I will do it :)

@albertopeam
Copy link
Contributor

@janndriessen could you close it? :)

@janndriessen
Copy link
Collaborator Author

@janndriessen could you close it? :)

Will be done automatically after the merge to master. New release should be coming this week.

@albertopeam
Copy link
Contributor

Thanks for the clarification :)

@janndriessen
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants