Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to use next 14 and app router #19

Merged
merged 5 commits into from
May 29, 2024

Conversation

PaulBratslavsky
Copy link

Ready for review.

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextly-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 11:16am

Copy link
Collaborator

@surjithctly surjithctly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thanks so much for your PR. Can you make sure the original design stay same? because I see testimonials, footer etc are changed. Also the source code includes unwanted files like /utils.

The Theme Toggle is also bit different and it doesn't appear sometimes. do you know why?

@PaulBratslavsky
Copy link
Author

Will take a look. Thanks.

…nal design. Look identical two the original site. I did not have any issue with the theme button.
@PaulBratslavsky
Copy link
Author

@surjithctly I made the changes that you asked for. Let me know if there is anything else.

@surjithctly
Copy link
Collaborator

now the components have moved, the root folder is no more required right? Also remove [StrapiImage.tsx] from the components or any similar which are not in use.

It is throwing build error.

Thanks so much for your work. I really appreciate it.

…lder and it is something that is selected by default when running create-next-app
@PaulBratslavsky
Copy link
Author

@surjithctly cool I removed the StrapiImage.tsx file since it is no longer being used.

I typically like to keep the src folder and it is something that is set to "yes" by default when running create-next-app

I ran 'yarn build' to test, everything worked. Let me know if there is anything else. Thanks.

@surjithctly
Copy link
Collaborator

Thanks, I meant the /components folder, which is now in two places. one is root and one inside /src, so only one is needed right?

@PaulBratslavsky
Copy link
Author

PaulBratslavsky commented May 28, 2024

@surjithctly yes, thank you. I used that folder as reference when refactoring. Forgot to remove it. Just update it and removed the unused components folder.

@surjithctly surjithctly merged commit c591f7d into web3templates:main May 29, 2024
1 of 2 checks passed
@surjithctly
Copy link
Collaborator

Thank you for your effort @PaulBratslavsky

It's merged.

@PaulBratslavsky
Copy link
Author

@surjithctly glad I can help.🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants