Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Symbol Source #67

Open
thargy opened this issue Nov 7, 2018 · 2 comments
Open

Replace Symbol Source #67

thargy opened this issue Nov 7, 2018 · 2 comments
Labels
breaking A breaking change enhancement A new feature, or an improvement to an existing feature
Milestone

Comments

@thargy
Copy link
Contributor

thargy commented Nov 7, 2018

As the current implementation tries to deploy to defunct symbol servers we should change to using GitHub SourceLink.

@thargy thargy added enhancement A new feature, or an improvement to an existing feature breaking A breaking change labels Nov 7, 2018
@thargy thargy added this to the V6 Release milestone Nov 7, 2018
@josh-green
Copy link
Contributor

@thargy
Copy link
Contributor Author

thargy commented Nov 21, 2018

James Newton-King seems to suggest symbol packages are currently 'useless' (https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink)

Ordinarily, you'd publish symbol files in a symbol package. Currently the main public host for symbol packages doesn't support the portable symbol files (*.pdb) created by SDK-style projects, and symbol packages aren't useful.

However, NuGet/Home#6104 (comment) shows that there's still a lot of confusion and discussion ongoing so we should monitor carefully to see where it ends up! The discussion is quite interesting and continues in dotnet/docs#9110.

Overall, JNK has done some pretty good investigation for the guidance and is definitely an authority of package publication so we should follow the published guidance, whatever it ends up being. I suspect it will end up as 'do all the above'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change enhancement A new feature, or an improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants