-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not panic on AzureRM Errors #44
Comments
Seeing the same. Creates gaps in all metrics gathered. Would prefer if it just wrote an error |
The underlying issue is that
This is basically what is being done here and putting it into the playground quickly shows that it fails. package main
import (
"fmt"
)
func foo() {
panic("foobar")
}
func main() {
foo()
recover := recover()
fmt.Println(recover)
} The really BIG problem is that this incorrect treatment of errors is used for the back-off-retry mechanic in github.com/webdevops/go-common/prometheus/collector IMO this entire behavior should be broken Currently I am working on putting a bandaid at least onto the cost collector to get rid of this issue. However an entire rework of error handling in (at least) this project, the azure-resourcegraph-exporter and go-common is required Furthermore I don't understand why the prometheus go client library is not used more extensively here |
Hi,
from time to time we are receiving error from Azure for cost management related errors.
Some of them are persistent and after five retries, the exporter will be panic and exited.
I would like to ask, if the behavior can be changed from panic level to error level. I do not need any benefit of letting the exporter terminate.
Example panic trace after 5 retries:
The text was updated successfully, but these errors were encountered: