-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In development mode, js references are lost in html and pathData.filename is lost in function when js.filename is a function after the project hot update #66
Comments
Hello @dreampasssser, thanks for the issue report. I will fix it. |
@webdiscus Well, I also found that the latest version of the Plugin is 3.4.4, but it is still at 3.1.3 in Github releases. There must be something wrong. |
the missing const path = require('path');
module.exports = {
mode: 'production',
output: {
path: path.join(__dirname, 'dist/'),
filename: (pathData) => {
const { filename } = pathData;
console.log('-- JS.filename: ', {
filename, // => undefined
});
return '[name].bundle.js';
},
},
entry: {
main: './src/main.js', // => dist/main.bundle.js
},
}; But I have fixed the issue in the plugin. I just test it by me local. |
the You can use the manual watch test to create a simple repo if you have any issue. |
Oh, you are so efficient. I checked it, it's OK. The |
I'm sorry, the |
That's all right! |
Current behaviour
As the title says.
Expected behaviour
Js references are not lost in html and pathData.filename is not lost in function.
Reproduction Example
You can just use the example 'simple-site', in order to keep the folder structure, I wrote a function:
This can generate a new name, use it like this:
It works when npm run build and the 1st time npm run start, but when you modify a style in scss file, it will not work, the loss as title says will happen.
Environment
Additional context
None.
The text was updated successfully, but these errors were encountered: