fix(@wdio/sauce-service): replace vulnerable ip module with a maintai…

…ned package
webdriverio · Aug 28, 2024 · 73bdc0f · 73bdc0f
1 parent 2ab8239
commit 73bdc0f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/wdio-sauce-service/package.json b/packages/wdio-sauce-service/package.json
@@ -33,7 +33,7 @@
     "@wdio/logger": "8.38.0",
     "@wdio/types": "8.40.3",
     "@wdio/utils": "8.40.3",
-    "ip": "^2.0.1",
+    "address": "^2.0.3",
     "saucelabs": "8.0.0",
     "webdriverio": "8.40.3"
   },

diff --git a/packages/wdio-sauce-service/src/launcher.ts b/packages/wdio-sauce-service/src/launcher.ts
@@ -1,6 +1,6 @@
 import { performance, PerformanceObserver } from 'node:perf_hooks'
 
-import ip from 'ip'
+import { ip } from 'address'
 import {
     default as SauceLabs,
     type SauceLabsOptions,
@@ -51,7 +51,7 @@ export default class SauceLauncher implements Services.ServiceInstance {
             noAutodetect: true,
             tunnelIdentifier: sauceConnectTunnelIdentifier,
             ...this._options.sauceConnectOpts,
-            noSslBumpDomains: `127.0.0.1,localhost,${ip.address()}` + (
+            noSslBumpDomains: `127.0.0.1,localhost,${ip()}` + (
                 this._options.sauceConnectOpts?.noSslBumpDomains
                     ? `,${this._options.sauceConnectOpts.noSslBumpDomains}`
                     : ''