From 44b5bc0d72a2d4542f618743f9b11be250893d8a Mon Sep 17 00:00:00 2001 From: lalli-flores Date: Mon, 9 Dec 2019 18:32:37 -0800 Subject: [PATCH] fix(MeetingsAdapter): update Meeting definition to match ad-hoc meetings --- src/MeetingsAdapter.js | 6 ++---- src/MeetingsAdapter.test.js | 26 ++++++++++++++------------ 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/MeetingsAdapter.js b/src/MeetingsAdapter.js index 31d74a9..e22ea77 100644 --- a/src/MeetingsAdapter.js +++ b/src/MeetingsAdapter.js @@ -8,13 +8,11 @@ import WebexAdapter from './WebexAdapter'; * @typedef {Object} Meeting * @property {string} ID The meeting identifier. * @property {string} title The title of the meeting. - * @property {string} startTime The time and date of the start of the meeting. Must be a valid date-time string. - * @property {string} endTime The time and date of the end of the meeting. Must be a valid date-time string. * @property {MediaStreamTrack} localVideo The local video stream track. * @property {MediaStreamTrack} localAudio The local audio stream track. * @property {MediaStream} localShare The local media share stream. - * @property {MediaStreamTrack} remoteVideo The remote video stream track. - * @property {MediaStreamTrack} remoteAudio The remote audio stream track. + * @property {MediaStream} remoteVideo The remote video stream. + * @property {MediaStream} remoteAudio The remote audio stream. * @property {MediaStream} remoteShare The remote media share stream. */ diff --git a/src/MeetingsAdapter.test.js b/src/MeetingsAdapter.test.js index 40ab6ac..2aef3c9 100644 --- a/src/MeetingsAdapter.test.js +++ b/src/MeetingsAdapter.test.js @@ -13,18 +13,20 @@ describe('Meetings Adapter Interface', () => { meetingsAdapter = null; }); - test('getMeeting() returns an observable', () => { - expect(isObservable(meetingsAdapter.getMeeting())).toBeTruthy(); - }); - - test('getMeeting() errors because it needs to be defined', (done) => { - meetingsAdapter.getMeeting('meetingID').subscribe( - () => {}, - (error) => { - expect(error.message).toBe('getMeeting(ID) must be defined in MeetingsAdapter'); - done(); - } - ); + describe('getMeeting()', () => { + test('returns an observable', () => { + expect(isObservable(meetingsAdapter.getMeeting())).toBeTruthy(); + }); + + test('errors because it needs to be defined', (done) => { + meetingsAdapter.getMeeting('meetingID').subscribe( + () => {}, + (error) => { + expect(error.message).toBe('getMeeting(ID) must be defined in MeetingsAdapter'); + done(); + } + ); + }); }); test('addLocalMedia() errors because it needs to be defined', () => {