Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce priority for Doctrine event subscriber #6

Merged
merged 2 commits into from
Apr 30, 2017

Conversation

xkons
Copy link
Contributor

@xkons xkons commented Apr 28, 2017

This way I can be sure that objects that are to be translated are actually ready.

@coveralls
Copy link

coveralls commented Apr 28, 2017

Coverage Status

Coverage decreased (-1.06%) to 84.615% when pulling 5d037a9 on add_event_subscriber_service_priority into f227c8b on master.

@mpdude mpdude changed the title Set service priority for Doctrine event subscriber below 0 Reduce priority for Doctrine event subscriber Apr 29, 2017
@mpdude
Copy link
Member

mpdude commented Apr 29, 2017

The use case is that if you have additional life cycle event listeners set up in Doctrine that initialize fields marked as translatable, we want Polyglot to handle these fields (injecting the value holders) somewhat later.

In result, it should be possible to use Polyglot also for fields not managed directly by Doctrine, but by additional extensions depending on the postLoad event.

@mpdude
Copy link
Member

mpdude commented Apr 29, 2017

@xkons Fine!

Could you please add a short changelog entry as well ("changed priority ... to -100... to defer injection of translation objects..." or similar), and then merge this and create a release tag? I think this qualifies as a bugfix.

Thanks!

@mpdude mpdude force-pushed the add_event_subscriber_service_priority branch from 5d037a9 to c8a4045 Compare April 30, 2017 14:02
@mpdude mpdude force-pushed the add_event_subscriber_service_priority branch from 325c535 to a56dfcf Compare April 30, 2017 14:06
@mpdude mpdude merged commit a8f1edc into master Apr 30, 2017
@mpdude mpdude deleted the add_event_subscriber_service_priority branch April 30, 2017 14:07
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.599% when pulling a56dfcf on add_event_subscriber_service_priority into 6df74af on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants