Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Off-by-one error with hint-css-prefix-order #1955

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

antross
Copy link
Member

@antross antross commented Feb 22, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Locations reported by postcss are one-based wheraes those used within
webhint are zero-based. The hint-compat-api already accounted for
this discrepency and now hint-css-prefix-order does as well.

Locations reported by `postcss` are one-based wheraes those used within
`webhint` are zero-based. The hint-compat-api already accounted for
this discrepency and now hint-css-prefix-order does as well.
Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this once I finish publishing the packages

@molant molant merged commit 091a3b1 into webhintio:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants