Fix linting problems #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently some of the core ESLint rules have issues with TypeScript-specific concepts. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: eslint/typescript-eslint-parser#77
alrra
commented
Mar 9, 2017
| @@ -3,9 +3,10 @@ | |||
| * @author Anton Molleda (@molant) based on Nicholas C. Zakas ESLint (https://github.com/eslint/eslint/blob/master/lib/rule-context.js) | |||
| */ | |||
|
|
|||
| import { validate as ruleValidator } from './config/config-rules'; | |||
| /* eslint-disable no-unused-vars */ | |||
There was a problem hiding this comment.
@molant We could just drop no-unused-vars and use the noUnusedLocals and noUnusedParameters TypeScript compiler options (as one suggested on the ESLint related issue, but that has its limitations).
There was a problem hiding this comment.
I've refactored a bit the code and now we don't need to import the types. There are still a couple no-unused-vars out there but not as many as it used to be. I think we should be ok for now but if we see things start getting out of control again we can review this again.
|
Closing this in favor of #36. From what I've seen there shouldn't be too many changes and the merge was mostly clean. Hopefully you don't have a lot of problems with your current work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the core ESLint rules have issues with TypeScript-specific concepts.
See also: eslint/typescript-eslint-parser#77