Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

tmz.com timeout with axe rule in the scanner #103

Closed
sarvaje opened this issue Mar 15, 2018 · 6 comments
Closed

tmz.com timeout with axe rule in the scanner #103

sarvaje opened this issue Mar 15, 2018 · 6 comments
Assignees
Labels

Comments

@sarvaje
Copy link
Contributor

sarvaje commented Mar 15, 2018

No description provided.

@molant
Copy link
Member

molant commented Mar 15, 2018

Is this using 0.24 or 1.x? The latest 1.x should be using axe-core-betaX that has quite a few speed improvements.

@sarvaje
Copy link
Contributor Author

sarvaje commented Mar 15, 2018

1.x
Using directly sonarwhal it works, but not in the scanner (also in local)

@sarvaje
Copy link
Contributor Author

sarvaje commented Mar 19, 2018

@molant @alrra, I'm able to reproduce this in local. Now I'm investigating why the scanner is not handling this ok. The scanner should finish in a reasonable time, but for some reason, when sonarwhal returns the timeout error, the queue message lock has expired and the message is back to the queue (that's why it takes forever)

@molant
Copy link
Member

molant commented Oct 18, 2018

Did you end up figuring out what was wrong?

@sarvaje
Copy link
Contributor Author

sarvaje commented Oct 19, 2018

@molant axe still timeout with jsdom and tmz.com (but this happens with or without scanner), but everything work as expected now and the scanner capture the timeout without problems.

I think we can close this issue.

@molant
Copy link
Member

molant commented Oct 20, 2018

I agree. Hopefully dequelabs/axe-core#1172 will get merged and things will improved enough to run it via jsdom 😊

@molant molant closed this as completed Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants