Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringClassReference sniff - better detection possible string classes #8

Merged
merged 2 commits into from
May 11, 2019

Conversation

michalbundyra
Copy link
Member

In PHP string backslash can be escaped. Tokenizer returns content with escape character so we need to replace drop these escape characters.

We can also return early when name contains spaces as it cannot be a valid class name.

In PHP string backslash can be escaped. Tokenizer returns content with
escape character so we need to replace drop these escape characters.
We can also reaturn early when name contains spaces as it cannot be
a valid class name.
@michalbundyra michalbundyra added the bug Something isn't working label May 9, 2019
@michalbundyra michalbundyra added this to the 1.0.1 milestone May 9, 2019
michalbundyra added a commit that referenced this pull request May 11, 2019
StringClassReference sniff - better detection possible string classes
michalbundyra added a commit that referenced this pull request May 11, 2019
michalbundyra added a commit that referenced this pull request May 11, 2019
michalbundyra added a commit that referenced this pull request May 11, 2019
@michalbundyra michalbundyra merged commit 0657d39 into master May 11, 2019
@michalbundyra michalbundyra deleted the hotfix/string-reference branch May 11, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant