fix(app-admin): allow users to adjust the SplitView columns width across all apps #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leopuleo
force-pushed
the
leo/fix/adjustable-main-view-columns
branch
from
dfe9f89 to
fc9df39
Compare
Pavel910
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we are updating the
SplitView,LeftPanelandRightPanelto allow users to adjust the columns' width.There is no need to update the existing
<SplitView>.We include the
layoutIdprop for the ACO-powered applications to store the latest column width inlocalStorage.The function
useLayoutIdis included in all ACO-powered applications to create a consistent local storage key that tracks column width. The function receives theapplicationIdand generates thelayoutIdbased on the currenttenantIdandlocalCode.CleanShot.2024-06-21.at.12.23.30.mp4
How Has This Been Tested?
Manually + Cypress
Documentation
@swapnilmmane, perhaps it would be beneficial for us to add an article to the user guide.