Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content entry traverser #4196

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Content entry traverser #4196

merged 5 commits into from
Jul 10, 2024

Conversation

Pavel910
Copy link
Collaborator

@Pavel910 Pavel910 commented Jul 8, 2024

Changes

This PR adds better test data for Content Entry Traverser, and improves data normalization and storage.

  • single value fields with children (object and dynamic zone) now correctly generate field path while traversing data
  • falsy values are no longer skipped and will be visited (null, false, [], "")
  • DZ input is now normalized on the GraphQL resolver level, before the input is passed to Webiny domain logic
  • DZ StorageTransform plugin was removed, as it's no longer necessary. This also improved performance of get/list operations, since there's no more redundant data transformation when data is fetched from storage.
  • CmsModelFieldToGraphQL plugin now supports an optional normalizeInput function on the manage endpoint, so individual fields can implement data normalization

How Has This Been Tested?

Jest test.

@Pavel910 Pavel910 added the bug label Jul 8, 2024
@Pavel910 Pavel910 added this to the 5.40.2 milestone Jul 8, 2024
@Pavel910 Pavel910 self-assigned this Jul 8, 2024
@Pavel910 Pavel910 requested a review from adrians5j July 8, 2024 10:56
@Pavel910 Pavel910 merged commit c074bca into dev Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants