Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-headless-cms): do not set dirty model unless it changed #4207

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

brunozoric
Copy link
Contributor

Changes

When user tries to edit a model, but they do not change anything, and then try to navigate away from the model - they get a popup blocking them from navigating away.
This was because we set a model as a dirty (changed) on model load.

How Has This Been Tested?

Manually.

@brunozoric brunozoric requested a review from Pavel910 July 24, 2024 08:20
@brunozoric brunozoric self-assigned this Jul 24, 2024
@brunozoric brunozoric added this to the 5.40.4 milestone Jul 24, 2024
@brunozoric brunozoric added the cms label Jul 24, 2024
@brunozoric brunozoric marked this pull request as ready for review July 24, 2024 09:43
@brunozoric brunozoric force-pushed the bruno/fix/app-headless-cms/navigate-from-model branch from c3bf746 to bbb449a Compare July 26, 2024 12:49
@brunozoric brunozoric merged commit 4a16b87 into dev Jul 29, 2024
92 checks passed
@brunozoric brunozoric deleted the bruno/fix/app-headless-cms/navigate-from-model branch October 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants