Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module-info.java file #117

Open
Sineaggi opened this issue Sep 6, 2023 · 4 comments
Open

Add module-info.java file #117

Sineaggi opened this issue Sep 6, 2023 · 4 comments

Comments

@Sineaggi
Copy link

Sineaggi commented Sep 6, 2023

To run the library in a modular world, on the module path.

@jamesward
Copy link
Member

I'd love a pull request for this since I'm not familiar with the best way to do it.

@Sineaggi
Copy link
Author

Sineaggi commented Sep 6, 2023

The easiest way is to bump java version to >8 (if possible) then add a module-info and verify all the tests still pass.

If 8 compatibility is required, then adding one via the moditect maven plugin might be the easiest route. https://github.com/moditect/moditect#generating-module-infojava-descriptors

@Sineaggi
Copy link
Author

Sineaggi commented Sep 6, 2023

Also it looks like the project depends on jsr305 annotations, which causes split packages with javax.annotation under java 9+. https://nipafx.dev/jsr-305-java-9/

@Sineaggi
Copy link
Author

Sineaggi commented Sep 7, 2023

[WARNING] * Required filename-based automodules detected: [jsr305-3.0.2.jar]. Please don't publish this project to a public artifact repository! *

Warning from maven's compiler plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants