Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing progress tracking #24

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

Informatic
Copy link
Member

@Informatic Informatic commented Jan 15, 2022

adblock: remove XHR/fetch shims altogether

These are useless for us anyways, and were causing some issues with progress tracking it seems.

One of our members tested this out by just disabling adblock altogether - all watched videos were properly tracked, while with it enabled (with YouTube premium still) some were missed.

Fixes #11
Fixes #17

These are useless for us anyways, and were causing some issues with
progress tracking it seems.
@Informatic Informatic changed the title adblock: remove XHR/fetch shims altogether Attempt at fixing progress tracking Jan 15, 2022
@Informatic
Copy link
Member Author

Test ipk with these changes built in: https://d.inf.re/b/abd79b6b24d85ef28b11a1061b899ce3.ipk

Single-command install, assuming you have Homebrew Channel installed - wait until you see {"returnValue":true,"statusText":"Finished.","finished":true} and you should be good to go:

luna-send -i 'luna://org.webosbrew.hbchannel.service/install' '{"ipkUrl":"http://d.inf.re/b/abd79b6b24d85ef28b11a1061b899ce3.ipk", "ipkHash":"6cc4f4321e56ccf33b06c9259d768dcab14077b94b6945ded363d84606a9f51e"}'

@1basti1
Copy link

1basti1 commented Jan 18, 2022

Used it since 2 days and no problems for me now.

@1basti1
Copy link

1basti1 commented Jan 24, 2022

It's been over a week and still no problems on my side. Seems to work.

@Informatic Informatic marked this pull request as ready for review January 24, 2022 09:12
@Informatic Informatic merged commit b4869c1 into main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube does not save the video stop location Does not save videos to YouTube
2 participants