fix(preProcessPatterns): support glob context paths with special characters #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexander-akait
requested changes
Jan 24, 2018
|
Oddly, |
clydin
force-pushed
the
escape-glob-context
branch
8 times, most recently
from
6f877e3 to
b7bfb1a
Compare
|
Alright. Updated to be more comprehensive and with additional test cases. |
clydin
force-pushed
the
escape-glob-context
branch
from
b7bfb1a to
37bf5ba
Compare
alexander-akait
requested changes
Jan 25, 2018
src/preProcessPattern.js
Outdated
| @@ -7,6 +7,29 @@ import isObject from './utils/isObject'; | |||
| // https://www.debuggex.com/r/VH2yS2mvJOitiyr3 | |||
| const isTemplateLike = /(\[ext\])|(\[name\])|(\[path\])|(\[folder\])|(\[emoji(:\d+)?\])|(\[(\w+:)?hash(:\w+)?(:\d+)?\])|(\[\d+\])/; | |||
|
|
|||
| function escape(context, from) { | |||
There was a problem hiding this comment.
Move escape to src/utils
clydin
force-pushed
the
escape-glob-context
branch
from
37bf5ba to
3ed8b70
Compare
michael-ciniawsky
changed the title
This was referenced Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextpaths with special characters (i.e., glob characters) will cause files to not be copied. This is especially important when the context represents the absolute path to a location and the path is not under the control of the project using the plugin.Tests have been updated and additional test cases added.
Addresses: angular/angular-cli#9230