Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the noErrorOnMissing option #475

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 15, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

implement new options noErrorOnMissing + improve schema

Breaking Changes

Yes, for schema

Additional Info

fixes #431 fixes #433

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #475 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   94.83%   94.90%   +0.07%     
==========================================
  Files           8        8              
  Lines         213      216       +3     
  Branches       56       58       +2     
==========================================
+ Hits          202      205       +3     
  Misses         11       11              
Impacted Files Coverage Δ
src/utils/createPatternGlob.js 100.00% <ø> (ø)
src/preProcessPattern.js 100.00% <100.00%> (ø)
src/processPattern.js 96.77% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5bc1b...d7302e8. Read the comment docs.

@alexander-akait alexander-akait merged commit e3803ce into master May 15, 2020
@alexander-akait alexander-akait deleted the issue-431 branch May 15, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to fail the build if a file is missing
1 participant