Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added types #650

Merged
merged 36 commits into from
Dec 10, 2021
Merged

feat: added types #650

merged 36 commits into from
Dec 10, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Added types

Breaking Changes

No

Additional Info

Yes, we had bugs with some very edge cases, I fixed them, also added todo for other edge cases

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #650 (3aff348) into master (f8aad69) will decrease coverage by 2.88%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
- Coverage   92.83%   89.94%   -2.89%     
==========================================
  Files           3        3              
  Lines         377      388      +11     
  Branches      109      119      +10     
==========================================
- Hits          350      349       -1     
- Misses         27       38      +11     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/utils.js 90.00% <83.33%> (-1.67%) ⬇️
src/index.js 89.88% <90.32%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8aad69...3aff348. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant